-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: clarify architecture, implement PayZen & implement Wompi #53
base: develop
Are you sure you want to change the base?
Conversation
db815c2
to
f5ef6f5
Compare
9c135bc
to
f1c2904
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some Noetes to self
This comment was marked as resolved.
This comment was marked as resolved.
Kindly help move this PR forward. Many thanks from Yours Sincerely! |
Kindly help move this PR forward. Many thanks from Yours Sincerely! |
Kindly help move this PR forward. Many thanks from Yours Sincerely! |
Kindly help move this PR forward. Many thanks from Yours Sincerely! |
Kindly help move this PR forward. Many thanks from Yours Sincerely! |
Kindly help move this PR forward. Many thanks from Yours Sincerely! |
Kindly help move this PR forward. Many thanks from Yours Sincerely! |
Kindly help move this PR forward. Many thanks from Yours Sincerely! |
Kindly help move this PR forward. Many thanks from Yours Sincerely! |
@blaggacao what's the state with this? really looking forward to mollie implementation but this seems to block it, right? |
@torstenhoegel I've been running an evolution of this in production successfully for over half a year now. The work ahead is some elaborate rebasing and cherry picking from that branch, improve test coverage and proceed with polishing and stabilization of the api + a compatibility layer inside erpnext to work with the new gateways. |
Thanks a lot for the update @blaggacao and for your continued work on this! It’s great to hear that it's been running smoothly in production for so long. I was wondering, do you have a rough timeline in mind for when the rebasing, test coverage improvements, and the API stabilization might be ready for release? No rush, just curious about when it might be expected. Thanks again for all your efforts! |
I hope we'd be measuring weeks not months, though it's not at the top of my priority lust, at this moment. But it didn't fall off, either. 😄 |
ERP Companion: frappe/erpnext#40845 🟢
Frappe Companion: frappe/frappe#25952 ✔️ & frappe/frappe#26324 ✔️ & frappe/frappe#26637 ✔️
closes #52
Rendered
@s-aga-r @ankush please let me know what you think of this direction.
webshop
in the futureresponse.raise_for_status()
)* This implementation is quite eagerly typed to aid with IDE support when implementing a new gateway.
** Walk through screenshots: #53 (comment)
Overview